Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update default experience configs on startup - only create them. #3605

Merged
merged 6 commits into from
Jun 20, 2023

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Jun 19, 2023

Closes #3604

Code Changes

  • Remove the code that updates any default experience configs that already exist to match the out-of-the-box experience configs in the yaml file.

Steps to Confirm

  • Startup the application
  • Verify you have two default experience configs created automatically on startup
  • Update an experience config via the admin UI
  • Bring the application down
  • Start the application again
  • Verify that your edits to that default experience config remain

Pre-Merge Checklist

Description Of Changes

Only create default experience configs on startup - don't update existing ones.

@cypress
Copy link

cypress bot commented Jun 19, 2023

Passing run #2793 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 9f53d68 into a8feeb1...
Project: fides Commit: bc165e7d76 ℹ️
Status: Passed Duration: 00:56 💡
Started: Jun 20, 2023 2:29 PM Ended: Jun 20, 2023 2:30 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (2834895) 87.06% compared to head (9f53d68) 87.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3605      +/-   ##
==========================================
- Coverage   87.06%   87.05%   -0.01%     
==========================================
  Files         310      310              
  Lines       19002    18995       -7     
  Branches     2427     2427              
==========================================
- Hits        16544    16537       -7     
  Misses       2029     2029              
  Partials      429      429              
Impacted Files Coverage Δ
src/fides/api/util/consent_util.py 99.40% <100.00%> (-0.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pattisdr pattisdr marked this pull request as ready for review June 19, 2023 16:00
@pattisdr pattisdr requested a review from adamsachs June 19, 2023 16:00
@pattisdr
Copy link
Contributor Author

@adamsachs hoping you have time to review this small change to default experience configs - I'm only creating them on startup, not updating now - context here: https://ethyca.slack.com/archives/C04S7K0T2V7/p1686944233741909

conflicts:
CHANGELOG.md
src/fides/api/util/consent_util.py
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just one small comment that i'm not even sure we'd want to address, certainly not worth holding this up unless it's quick and you think it's a good idea.

src/fides/api/util/consent_util.py Show resolved Hide resolved
@adamsachs adamsachs merged commit a361329 into main Jun 20, 2023
@adamsachs adamsachs deleted the fides_3604_exp_config_create_only_on_startup branch June 20, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't Update Existing Experience Configs on startup
2 participants