-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't update default experience configs on startup - only create them. #3605
Conversation
Passing run #2793 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3605 +/- ##
==========================================
- Coverage 87.06% 87.05% -0.01%
==========================================
Files 310 310
Lines 19002 18995 -7
Branches 2427 2427
==========================================
- Hits 16544 16537 -7
Misses 2029 2029
Partials 429 429
☔ View full report in Codecov by Sentry. |
@adamsachs hoping you have time to review this small change to default experience configs - I'm only creating them on startup, not updating now - context here: https://ethyca.slack.com/archives/C04S7K0T2V7/p1686944233741909 |
conflicts: CHANGELOG.md src/fides/api/util/consent_util.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! just one small comment that i'm not even sure we'd want to address, certainly not worth holding this up unless it's quick and you think it's a good idea.
Closes #3604
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Only create default experience configs on startup - don't update existing ones.