Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable connector dropdown in integration tab on save #3552

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

Kelsey-Ethyca
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca commented Jun 13, 2023

Closes #3535

Code Changes

Updated the ConnectionListDropdown to be disabled when a connectionConfig is saved.

Steps to Confirm

  • create a new system
  • nav to the integration tab - see that the dropdown in enabled and no connector is saved
  • use the dropdown to create a connector
  • fill in the form
  • click save
  • verify that once the connector saved the dropdown is disabled
  • delete the connector
  • verify the dropdown is enabled again

Pre-Merge Checklist

@cypress
Copy link

cypress bot commented Jun 13, 2023

Passing run #2651 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 27697a4 into ed56a20...
Project: fides Commit: e8db31944f ℹ️
Status: Passed Duration: 00:47 💡
Started: Jun 13, 2023 5:21 PM Ended: Jun 13, 2023 5:21 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Kelsey-Ethyca Kelsey-Ethyca merged commit 0626375 into main Jun 13, 2023
@Kelsey-Ethyca Kelsey-Ethyca deleted the kt-3535-diasable-connector-dropdown branch June 13, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable connector selection dropdown after a connector is saved in the system integration tab
2 participants