-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy center customisations #3432
Conversation
Passing run #2502 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3432 +/- ##
=======================================
Coverage 87.12% 87.12%
=======================================
Files 312 312
Lines 18757 18757
Branches 2389 2389
=======================================
Hits 16342 16342
Misses 1991 1991
Partials 424 424 ☔ View full report in Codecov by Sentry. |
clients/privacy-center/components/modals/consent-request-modal/ConsentRequestModal.tsx
Outdated
Show resolved
Hide resolved
…to sp/fde-12/custom-buttons
…to sp/fde-12/custom-buttons
@seanpreston I don't feel dangerous enough on the frontend to approve this, but nice work! 😅 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one small nit left with the modal query param logic
Closes https://github.com/ethyca/fde/issues/12
Description Of Changes
This PR adds the ability to customise more of the privacy centre:
title
of the consent button is not separate from themodalTitle
, which is the title that's displayed in the modalconfirmButtonText
adds an override to theContinue
buttons in the modalscancelButtonText
adds an override to theCancel
buttons in the modalsemail
andphone
identity_inputs
are now able to both beoptional
, as the privacy center will fallback to the anonymous IDfavicon_path
can now be changed to display a hosted faviconThe changes are made to be as backwards compatible as possible, to avoid the need for further config version translation logic.
Steps to Confirm
cd clients/privacy-center
turbo run dev
Pre-Merge Checklist
CHANGELOG.md