Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy center customisations #3432

Merged
merged 28 commits into from
Jun 7, 2023
Merged

Privacy center customisations #3432

merged 28 commits into from
Jun 7, 2023

Conversation

seanpreston
Copy link
Contributor

@seanpreston seanpreston commented Jun 1, 2023

Closes https://github.com/ethyca/fde/issues/12

Description Of Changes

This PR adds the ability to customise more of the privacy centre:

  • The title of the consent button is not separate from the modalTitle, which is the title that's displayed in the modal
  • confirmButtonText adds an override to the Continue buttons in the modals
  • cancelButtonText adds an override to the Cancel buttons in the modals
  • The email and phone identity_inputs are now able to both be optional, as the privacy center will fallback to the anonymous ID
  • The favicon_path can now be changed to display a hosted favicon

The changes are made to be as backwards compatible as possible, to avoid the need for further config version translation logic.

Steps to Confirm

  • cd clients/privacy-center
  • turbo run dev
  • Update the above options and observe they display text correctly
  • Remove the above options entirely and ensure they return to their defaults

Pre-Merge Checklist

@cypress
Copy link

cypress bot commented Jun 1, 2023

Passing run #2502 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 5414893 into d638d66...
Project: fides Commit: f9044d3782 ℹ️
Status: Passed Duration: 01:04 💡
Started: Jun 7, 2023 12:54 AM Ended: Jun 7, 2023 12:55 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d638d66) 87.12% compared to head (5414893) 87.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3432   +/-   ##
=======================================
  Coverage   87.12%   87.12%           
=======================================
  Files         312      312           
  Lines       18757    18757           
  Branches     2389     2389           
=======================================
  Hits        16342    16342           
  Misses       1991     1991           
  Partials      424      424           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seanpreston seanpreston marked this pull request as ready for review June 6, 2023 18:50
@ThomasLaPiana
Copy link
Contributor

@seanpreston I don't feel dangerous enough on the frontend to approve this, but nice work! 😅 🚀

Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small nit left with the modal query param logic

@seanpreston seanpreston merged commit 741bbce into main Jun 7, 2023
@seanpreston seanpreston deleted the sp/fde-12/custom-buttons branch June 7, 2023 15:32
seanpreston pushed a commit that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants