Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSR package export #3427

Merged
merged 33 commits into from
Jun 15, 2023
Merged

DSR package export #3427

merged 33 commits into from
Jun 15, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jun 1, 2023

Closes #3267 #3268 #3269

Code Changes

  • Added new html response format
  • Added the DsrReportBuilder that creates the HTML pages from templates and DSR data and bundles them in a zip file
  • Updated certain functions to accept the entire privacy request object instead of just the privacy request ID so we can have more information for the report

Steps to Confirm

  • Run nox -s "fides_env(test)" and submit an access request for [email protected]
  • The resulting zip file should appear under fides_uploads

Pre-Merge Checklist

@galvana galvana linked an issue Jun 1, 2023 that may be closed by this pull request
@cypress
Copy link

cypress bot commented Jun 2, 2023

Passing run #2729 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 0765536 into 219c3c0...
Project: fides Commit: 888f580cd9 ℹ️
Status: Passed Duration: 00:46 💡
Started: Jun 15, 2023 10:28 PM Ended: Jun 15, 2023 10:29 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 93.57% and project coverage change: -0.33 ⚠️

Comparison is base (5e8ae1f) 87.01% compared to head (2f19b02) 86.68%.

❗ Current head 2f19b02 differs from pull request most recent head 0765536. Consider uploading reports for the commit 0765536 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3427      +/-   ##
==========================================
- Coverage   87.01%   86.68%   -0.33%     
==========================================
  Files         311      312       +1     
  Lines       18871    18950      +79     
  Branches     2405     2413       +8     
==========================================
+ Hits        16420    16427       +7     
- Misses       2026     2100      +74     
+ Partials      425      423       -2     
Impacted Files Coverage Δ
...rc/fides/api/api/v1/endpoints/storage_endpoints.py 89.79% <ø> (ø)
src/fides/api/models/storage.py 90.56% <ø> (ø)
.../service/privacy_request/request_runner_service.py 77.17% <ø> (ø)
src/fides/api/util/storage_util.py 92.59% <77.77%> (-7.41%) ⬇️
...es/api/service/storage/storage_uploader_service.py 94.87% <88.88%> (+0.42%) ⬆️
.../privacy_request/dsr_package/dsr_report_builder.py 94.87% <94.87%> (ø)
src/fides/api/schemas/storage/storage.py 96.46% <100.00%> (+0.03%) ⬆️
src/fides/api/tasks/storage.py 77.21% <100.00%> (+2.82%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galvana galvana changed the title Initial draft of DSR package export DSR package export Jun 14, 2023
@galvana galvana marked this pull request as ready for review June 14, 2023 18:08
@galvana galvana merged commit 0fe6941 into main Jun 15, 2023
@galvana galvana deleted the 3267-dsr-package-export branch June 15, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create DSR access package export
2 participants