Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3260 Adds ability for fides.js to fetch its own geolocation #3356

Merged
merged 2 commits into from
May 23, 2023

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented May 23, 2023

Closes #3049 and #3260

Code Changes

  • Adds tests to confirm fides.js can fetch its own geolocation

Steps to Confirm

No core code changes, only tests added. If you wish to test, you'll have to look at console logs for now (until we get full stack working with real experience API calls):

  • in fides-js-components-demo.html, update experience and geolocation fidesConfig props to null or undefined
  • Set options.geolocationApiUrl to a valid geolocation api url (ask me for one)
  • Set options.isGeolocationEnabled to true
  • cd /clients, then npm run dev-pc
  • Navigate to http://localhost:3000/fides-js-components-demo.html, open console
  • Reload page, and see console log statement with geolocation data: e.g. Got location response from geolocation API, returning: {country: "US", ip: "63.173.339.012:13489", location: "US-CA", region: "CA"}

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@cypress
Copy link

cypress bot commented May 23, 2023

Passing run #2119 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge a686dee into 52bcd75...
Project: fides Commit: 4891adba7f ℹ️
Status: Passed Duration: 00:51 💡
Started: May 23, 2023 2:25 AM Ended: May 23, 2023 2:26 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, nice intercepts! 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to render correct overlay experience based on config
2 participants