3260 Adds ability for fides.js to fetch its own geolocation #3356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3049 and #3260
Code Changes
Steps to Confirm
No core code changes, only tests added. If you wish to test, you'll have to look at console logs for now (until we get full stack working with real experience API calls):
fides-js-components-demo.html
, updateexperience
andgeolocation
fidesConfig
props to null or undefinedoptions.geolocationApiUrl
to a valid geolocation api url (ask me for one)options.isGeolocationEnabled
totrue
cd /clients
, thennpm run dev-pc
http://localhost:3000/fides-js-components-demo.html
, open consoleGot location response from geolocation API, returning: {country: "US", ip: "63.173.339.012:13489", location: "US-CA", region: "CA"}
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats