-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend] Add Required Notice Key to Privacy Notices #3337
Conversation
Passing run #2110 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
…onvert names into valid fides keys.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3337 +/- ##
=======================================
Coverage 87.07% 87.08%
=======================================
Files 313 313
Lines 18970 18988 +18
Branches 2473 2475 +2
=======================================
+ Hits 16519 16536 +17
- Misses 2009 2010 +1
Partials 442 442
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! let's coordinate on FE changes...
OK @allisonking I'm creating the notice key if not supplied here as a temporary measure to move this forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, thanks @pattisdr !!
…igrate notice keys/
Closes #3281
❗ Contains migration
Description Of Changes
We need a key for each notice which will be exposed via the Fides consent cookie and the consent object for third parties to use when deciding to load scripts and pixes.
We want a notice key in the database. Out of the box we will pre-populate this but then we can edit it as needed. We will likely add some frontend UX to discourage changing this key. An important criteria right now is that the keys are not unique.
Internal context here
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md