-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend] Surface Current Preference under Privacy Experience List endpoint #3302
[Backend] Surface Current Preference under Privacy Experience List endpoint #3302
Conversation
Passing run #2043 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3302 +/- ##
=======================================
Coverage 87.06% 87.06%
=======================================
Files 309 309
Lines 18821 18847 +26
Branches 2461 2467 +6
=======================================
+ Hits 16386 16410 +24
- Misses 1995 1996 +1
- Partials 440 441 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, this makes sense to me!
Thanks so much for looking this over @allisonking! |
…List endpoint. If present, when embedding the privacy notices in the response it also queries for any saved preferences for that user and passes them along in the response.
…avor of the privacy experiences endpoint with embedded notices. Also remove verifying the address as we're looking at cors origins in middleware.
d35486c
to
088df1b
Compare
❗ Depends on #3193
❗ Note, this endpoint is not yet "public" that will be a follow-up ticket
Closes #3237
Description Of Changes
Add a
?fides_user_device_id
query param to the GET Privacy Experience List/Detail endpoint. This endpoint already embeds related privacy notices in the response. Add the current preferences of the user to each notice if they exist. Also add the default preferences for that endpoint.Code Changes
PrivacyExperience.get_related_privacy_notices
method to temporarily cache the "current_preference" or an "outdated_preference" to each privacy notice for the given user if applicable. I only add one or the other, or neither, not both. This lasts for the current session.fides_user_device_id
query param to both the privacy experience list and detail endpoints to additionally attach current preferences to embedded notices if they existSteps to Confirm
In postman collection:
Pre-Merge Checklist
CHANGELOG.md