-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration for system_dependencies
#3285
Conversation
Passing run #2512 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
@TheAndrewJackson I was curious if this was along the lines of what you were expecting as well. I think I need to pair a new |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3285 +/- ##
=======================================
Coverage 87.13% 87.14%
=======================================
Files 312 312
Lines 18761 18759 -2
Branches 2390 2390
=======================================
Hits 16348 16348
+ Misses 1989 1988 -1
+ Partials 424 423 -1
☔ View full report in Codecov by Sentry. |
This is in an ok state from the backend, the only failure seems to stem from the temporary installation from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SteveDMurphy This is looking good. It's exactly what I would have done
This may need to be combined with any other work related to #3334 |
Moved back to draft while I attempt to wrangle the front end required changes 😞 |
85c19fa
to
3d6c011
Compare
All tests are passing! Quite a few more snags with migration collisions but back into review, going to catch up to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes fidesplus#822
Code Changes
Steps to Confirm
The following scenarios have been tested successfully
Other?
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
A
fideslang
update will be required as well