-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mark 'export' CLI command as deprecated #3264
Conversation
2f81243
to
e30055e
Compare
Passing run #1892 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3264 +/- ##
=======================================
Coverage 87.39% 87.39%
=======================================
Files 305 305
Lines 18265 18267 +2
Branches 2384 2384
=======================================
+ Hits 15962 15964 +2
Misses 1866 1866
Partials 437 437
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated the deprecation command looks good, left a suggestion or topic of conversation around the response text is all
fba7b04
to
0214aaa
Compare
0214aaa
to
8ce596a
Compare
partially closes https://github.com/ethyca/fidesplus/issues/879
Code Changes
fides export
CLI commandSteps to Confirm
fides export datamap --csv -d .
in afides
container shell and got the following output2.12.2a1
tag that infidesplus
we can override this command and route it to thefidesplus
version that is not deprecated and is based on the migrated backing code infidesplus
Pre-Merge Checklist
export
command fromfides
#3265CHANGELOG.md
Description Of Changes
Initially we were going to remove the command wholesale. That PR can stay open for another release or two as we allow the command to be "phased out" more smoothly by being marked as deprecated. The
fides export
command infidesplus
will be able to override this deprecated command here and use all the code infidesplus
. This code should be effectively frozen until it is officially removed and phased out in the near future: #3265