-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove export command and backing code #3256
Conversation
Passing run #2141 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3256 +/- ##
==========================================
+ Coverage 87.03% 87.21% +0.18%
==========================================
Files 314 311 -3
Lines 19014 18586 -428
Branches 2474 2368 -106
==========================================
- Hits 16549 16210 -339
+ Misses 2021 1960 -61
+ Partials 444 416 -28
☔ View full report in Codecov by Sentry. |
discussion in slack for removal vs. deprecation: link |
e7963dc
to
f0948c5
Compare
@ThomasLaPiana @SteveDMurphy this should be a straightforward one, assuming we're good to remove this in |
@NevilleS you comfortable with removing this after official deprecation for a release? My gut feeling is yes, but we also don't know who's potentially using this. Worst-case they can fork and re-implement? |
Yup, let's do it 👍 |
cd0e23d
to
44f150c
Compare
@ThomasLaPiana do the code changes (removals) look alright to you? just need a ✅ before i can merge this in! |
@adamsachs oh gotcha, let me take a look! |
@adamsachs i got two more little ones hiding, I think this is good to go now! Approving but we can wait for the PR checks to be sure |
Partially closes https://github.com/ethyca/fidesplus/issues/879
Code Changes
export
CLI command and backing code inexport.py
andexport_helpers.py
(it will be moved over tofidesplus
)fidesplus
)Steps to Confirm
fides export
no longer works in corefides
with this change (should be an unrecognized command)fidesplus
side (see open PR here),fides export
command does work as expectedfidesplus
side that datamap UI still works as expectedPre-Merge Checklist
CHANGELOG.md
Description Of Changes
See fidesplus issue for context/motivation behind this migration