Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onesignal access test #3199

Merged
merged 9 commits into from
May 9, 2023
Merged

Onesignal access test #3199

merged 9 commits into from
May 9, 2023

Conversation

tmuralikrishnan
Copy link
Contributor

@tmuralikrishnan tmuralikrishnan commented May 2, 2023

Closes #1324

Code Changes

NEW SaaS Connector OneSignal for access and erasure

Steps to Confirm

  • Add/configure the OneSignal connector in UI
  • Verify OneSignal config and icon UI looks good
  • Add customer data using OneSignal API
  • Create an Access DSR with the new OneSignal customer email
  • Verify email sent by fides with customer data is correct
  • Create an update DSR with the new OneSignal customer email
  • Verify the customer data is now updated in OneSignal

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

SaaS Connector Checklist

  • Spec doc link
  • Vault Creds
  • Postman Collection
  • SaaS Config And Dataset
  • Access and Erasure Tests Passing
  • Icon

@cypress
Copy link

cypress bot commented May 2, 2023

Passing run #1853 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge cc2d75b into d94bf2c...
Project: fides Commit: 9af62cfec1 ℹ️
Status: Passed Duration: 00:48 💡
Started: May 9, 2023 10:43 PM Ended: May 9, 2023 10:44 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (d94bf2c) 87.39% compared to head (cc2d75b) 87.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3199      +/-   ##
==========================================
- Coverage   87.39%   87.38%   -0.01%     
==========================================
  Files         305      305              
  Lines       18265    18265              
  Branches     2384     2384              
==========================================
- Hits        15962    15961       -1     
- Misses       1866     1867       +1     
  Partials      437      437              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galvana galvana merged commit 525773a into main May 9, 2023
@galvana galvana deleted the onesignal-latest-muralikrishnan branch May 9, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OneSignal
2 participants