Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom field modal #3165

Merged
merged 47 commits into from
Apr 27, 2023
Merged

Custom field modal #3165

merged 47 commits into from
Apr 27, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Apr 26, 2023 •
edited
Loading

Closes #3079
Closes #3045

Code Changes

  • Add new custom field form modal
  • Update CustomFieldsList to support open text fields
  • Update empty table state to take a button slot
  • Update fides table to have a kebab menu and row clicks (thanks @allisonking )

Steps to Confirm

  • Run fidesplus edge build and admin ui
  • Test creating and editing custom fields.
  • Make sure that each field type is usable
  • The table empty state should also be able to add fields
  • Make sure that fields can be deleted

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

TheAndrewJackson and others added 24 commits April 21, 2023 16:28
@TheAndrewJackson
Add starting custom field modal
7ec5b5a
@TheAndrewJackson
Add initial form outline
76f2cdf
@TheAndrewJackson
Add original custom list item form
6c60558
@allisonking
Custom fields table enhancements (#3136)
6be45b4
@TheAndrewJackson
Add initial creation form
60f5173
@TheAndrewJackson
Merge branch 'ajackson_3079_custom_field_modal' of github.com:ethyca/…
0fff91d 
…fides into ajackson_3079_custom_field_modal
@TheAndrewJackson
Add initial edit+create form
aa49e20
@allisonking
Custom fields kebob menu for more actions (#3143)
8357455
@TheAndrewJackson
Fix dom validation issue
2d66157
@TheAndrewJackson
Fix formik issue
fc90c07
@TheAndrewJackson
Add ResourceType Cell
65a0b3a
@TheAndrewJackson
Remove allow list name and desc
b1c111c 
Also automatically set the name
@TheAndrewJackson
Add dynamic validation schema
0f18079
@TheAndrewJackson
update header text
9cbe681
@TheAndrewJackson
Move form into dedicated component
551a0ce 
Also validate form on select option
@TheAndrewJackson
Update openapi types
49ba03d
@TheAndrewJackson
Fix field type bug
6f4a0e8
@TheAndrewJackson
Add support for privacy declaration resource type
975a142
@TheAndrewJackson
Strip out allow_list
bd49867
@TheAndrewJackson
Update field type cell
46c62fb
@TheAndrewJackson
Apply slack feedback
e9c4d1f
@TheAndrewJackson
Update EmptyTableState.tsx
b28af5a
@TheAndrewJackson
polish fixes
f46e929
@TheAndrewJackson
update display values
a5a5fbe
@TheAndrewJackson TheAndrewJackson self-assigned this Apr 26, 2023
@cypress
Copy link

cypress bot commented Apr 26, 2023 •
edited
Loading

Passing run #1614 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 033e741 into ff18619...
Project: fides Commit: 2887ef4872 ℹ️
Status: Passed Duration: 00:54 💡
Started: Apr 26, 2023 9:05 PM Ended: Apr 26, 2023 9:06 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review April 26, 2023 16:33
allisonking
allisonking reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whew this is a lot, nice job figuring it all out! especially for such a complex feature. I left a few comments though I don't think there's anything blocking

clients/admin-ui/src/features/common/SearchBar.tsx Show resolved Hide resolved
clients/admin-ui/src/features/common/custom-fields/constants.ts Outdated Show resolved Hide resolved
clients/admin-ui/src/features/common/form/inputs.tsx Show resolved Hide resolved
clients/admin-ui/src/features/common/nav/v2/nav-config.ts Show resolved Hide resolved
clients/admin-ui/src/features/common/form/inputs.tsx Show resolved Hide resolved
clients/admin-ui/src/features/custom-fields/CustomFieldModal.tsx Show resolved Hide resolved
clients/admin-ui/src/features/custom-fields/CustomFieldModal.tsx Outdated Show resolved Hide resolved
clients/admin-ui/src/features/custom-fields/CustomFieldModal.tsx Outdated Show resolved Hide resolved
clients/admin-ui/src/features/custom-fields/cells.tsx Outdated Show resolved Hide resolved
clients/admin-ui/src/features/custom-fields/cells.tsx Show resolved Hide resolved
TheAndrewJackson and others added 15 commits April 26, 2023 16:07
@TheAndrewJackson
Remove comment
1efefbd
@TheAndrewJackson @allisonking
Update clients/admin-ui/src/features/custom-fields/CustomFieldForm.tsx
180d5bd 
Co-authored-by: Allison King <[email protected]>
@TheAndrewJackson @allisonking
Update clients/admin-ui/src/features/custom-fields/CustomFieldForm.tsx
6f0d144 
Co-authored-by: Allison King <[email protected]>
@TheAndrewJackson
Remove unused code
891ca7a
@TheAndrewJackson
Remove console log
1733993
@TheAndrewJackson
Fix typo
082dac2
@TheAndrewJackson
Remove comment
3885177
@TheAndrewJackson
Add comment explaining hack
d9a251c
@TheAndrewJackson
Add comment
037704d
@TheAndrewJackson @allisonking
Update clients/admin-ui/src/features/custom-fields/CustomFieldModal.tsx
9dcf0a5 
Co-authored-by: Allison King <[email protected]>
@TheAndrewJackson
Merge remote-tracking branch 'origin/ajackson_3079_custom_field_modal…
f163150 
…' into ajackson_3079_custom_field_modal
@TheAndrewJackson
Format
607aea7
@TheAndrewJackson
Remove prop type
9edf961
@TheAndrewJackson @allisonking
Update clients/admin-ui/src/features/custom-fields/CustomFieldModal.tsx
033e741 
Co-authored-by: Allison King <[email protected]>
@TheAndrewJackson
Merge remote-tracking branch 'origin/ajackson_3079_custom_field_modal…
0782bb6 
…' into ajackson_3079_custom_field_modal
@TheAndrewJackson
Copy link
Contributor Author

@allisonking I think everything from the first review has been addressed. I'll create the follow up tickets now and link them here

@TheAndrewJackson
Copy link
Contributor Author

Follow up tickets

allisonking
allisonking approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@TheAndrewJackson TheAndrewJackson merged commit cf3f547 into main Apr 27, 2023
@TheAndrewJackson TheAndrewJackson deleted the ajackson_3079_custom_field_modal branch April 27, 2023 13:38
TheAndrewJackson added a commit that referenced this pull request Apr 27, 2023
@TheAndrewJackson @allisonking
Custom field modal (#3165)
05aa79c 
Co-authored-by: Allison King <[email protected]>
@allisonking allisonking mentioned this pull request Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonking allisonking allisonking approved these changes

Assignees

@TheAndrewJackson TheAndrewJackson

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TheAndrewJackson @allisonking