Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy notice table scopes #3007

Merged
merged 7 commits into from
Apr 10, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Apr 7, 2023

Closes https://github.com/ethyca/fidesplus/issues/742

Code Changes

  • Add scope restrictions for:
    • Clicking on a row in a table to edit it
    • Toggling the enable toggle
    • Button to "Add a privacy notice"
  • Cypress tests

Steps to Confirm

  • Create a viewer user
  • Again, you'll need privacy notices, see Privacy notice table #3001 for steps to add those
  • As the viewer user, visit /consent/privacy-notices
  • Clicking on a row should not do anything
  • You should not see the "Add a privacy notice" button
  • The enable toggles should be disabled

Pre-Merge Checklist

Description Of Changes

image

@cypress
Copy link

cypress bot commented Apr 7, 2023

Passing run #1254 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge 39b4391 into dd3fc1b...
Project: fides Commit: cc85a25e35 ℹ️
Status: Passed Duration: 00:45 💡
Started: Apr 10, 2023 3:09 PM Ended: Apr 10, 2023 3:10 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review April 7, 2023 17:08
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@allisonking allisonking merged commit 8cd6474 into main Apr 10, 2023
@allisonking allisonking deleted the aking/fidesplus-742/privacy-notice-table-scopes branch April 10, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants