Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy notice initial page and redux #2995

Merged
merged 8 commits into from
Apr 6, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Apr 5, 2023

Closes https://github.com/ethyca/fidesplus/issues/736

Code Changes

  • Add privacy notice page and flag
  • Add privacy notice GET and state to redux store
  • Add a very basic "table" component just to show the API call is working
  • Add the page to the nav
  • Basic cypress test to make sure approvers can't see the page

Steps to Confirm

  • npm run dev against nox -s fides_env -- prod_edge in the fidesplus repo
  • Click on "Privacy requests"
  • Click on "Privacy notices" in the side nav
  • You'll probably get an empty state message
  • Seed your db with a privacy notice
    • I don't know if there's an easier way, but here's what I did:
$ noglob http POST localhost:8080/api/v1/privacy-notice 'Authorization: Bearer [token which I copied from the Network requests tab] \
[0][name]="test" [0][consent_mechanism]="opt_in" [0][data_uses][]=advertising [0][regions][]=us_ca [0][enforcement_level]="frontend"
  • The privacy notice should now appear in the FE (at an extremely basic level! just the name and the mechanism listed)

Note: this is flagged off by the feature flag privacyNotices which is enabled in dev and test but not prod. It is not a user configurable flag, meaning it won't show up as one the user can turn on via the UI (only through flags.json)

Pre-Merge Checklist

Description Of Changes

image

@cypress
Copy link

cypress bot commented Apr 5, 2023

Passing run #1185 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge 6ca3987 into 78865fb...
Project: fides Commit: 3face4aa94 ℹ️
Status: Passed Duration: 00:47 💡
Started: Apr 5, 2023 8:34 PM Ended: Apr 5, 2023 8:34 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review April 6, 2023 13:47
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small question about some RTK stuff. Feel free to leave it the same

@allisonking allisonking merged commit e5b39e2 into main Apr 6, 2023
@allisonking allisonking deleted the aking/fidesplus-736/privacy-notice-scaffold branch April 6, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants