Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python version from 3.10.7 to 3.10.11 #2936

Merged
merged 7 commits into from
Apr 7, 2023
Merged

Conversation

daveqnet
Copy link
Contributor

@daveqnet daveqnet commented Mar 28, 2023

Closes #

Code Changes

  • Bumped python version in main Dockerfile
  • Bumped python version in docs Dockerfile
  • Bumped python version in GitHub Actions workflow files

Steps to Confirm

  • Run python --version on fides app image

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@daveqnet daveqnet added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Mar 28, 2023
@cypress
Copy link

cypress bot commented Mar 28, 2023

Passing run #1207 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge 2bf5ca7 into e5b39e2...
Project: fides Commit: ca989e8d21 ℹ️
Status: Passed Duration: 00:37 💡
Started: Apr 7, 2023 12:48 PM Ended: Apr 7, 2023 12:48 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (e5b39e2) 86.91% compared to head (2bf5ca7) 86.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2936      +/-   ##
==========================================
- Coverage   86.91%   86.89%   -0.02%     
==========================================
  Files         303      303              
  Lines       17274    17274              
  Branches     2215     2215              
==========================================
- Hits        15013    15011       -2     
- Misses       1847     1848       +1     
- Partials      414      415       +1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daveqnet daveqnet marked this pull request as ready for review March 29, 2023 09:23
@daveqnet
Copy link
Contributor Author

Hi @ThomasLaPiana, I just bumped these so that our Docker images based on Debian would also be bumped to latest, but let me know if there are some application impacts I haven't considered.

Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@ThomasLaPiana
Copy link
Contributor

@daveqnet LGTM! Any chance you could tackle this on plus too? 😁

@daveqnet
Copy link
Contributor Author

@daveqnet LGTM! Any chance you could tackle this on plus too? 😁

Done! 🙂

https://github.com/ethyca/fidesplus/pull/785

@daveqnet daveqnet changed the title Bump python version from 3.10.7 to 3.10.10 Bump python version from 3.10.7 to 3.10.11 Apr 7, 2023
@daveqnet daveqnet merged commit 4012567 into main Apr 7, 2023
@daveqnet daveqnet deleted the dq-python-version-bump branch April 7, 2023 13:22
daveqnet added a commit that referenced this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants