-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict user management capabilities when using the viewer role #2933
Restrict user management capabilities when using the viewer role #2933
Conversation
Passing run #1071 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
It appears the backend does not allow editing a user's name if they don't have the USER UPDATE permission (even if it's their own user) The docstring here is not quite right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backend looks reasonable Allison! didn't review the FE
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2933 +/- ##
=======================================
Coverage 86.66% 86.66%
=======================================
Files 300 300
Lines 16909 16912 +3
Branches 2157 2158 +1
=======================================
+ Hits 14654 14657 +3
Misses 1844 1844
Partials 411 411
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@allisonking I'm testing this out locally, and as a |
I'm unsure if this was introduced here or has always been an issue, but attempting to update password where the Otherwise, I've tested the happy path here as a viewer, and everything else looks and functions great! |
Thanks @eastandwestwind ! Looks like that's a bug independent of this PR, so I'll log an issue for it and keep this PR trucking along 🚚 issue here: #2942 |
relies on a fidesui change. need https://github.com/ethyca/fidesui/pull/46 to go in first, then update the import here, before mergingCloses https://github.com/ethyca/fidesplus/issues/700
Code Changes
Steps to Confirm
viewer
rolePre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats