use HTML property, not text, when dispatching Mailchimp Transactional emails

[seanpreston]

Description

This PR updates the Mailchimp Transactional adaptor to use the html attribute, and subsequently render html correctly in emails.

[adamsachs]

this looks good. just noting, per @seanpreston , this was tested manually by a customer. we don't have any automated integration tests with mailchimp transactional so it'd be difficult to have automated coverage for this code path at this point.

@seanpreston my only concern is related to your question before about whether we have any non-html templates. can you think of anything that would make this a bit more robust/fail more obviously in the case that we do get a non-HTML template into our code base? maybe some automated test around that?

not gonna hold this up for that though :)

[cypress]

Passing run #958 ↗︎

0	3	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Merge 971166b into 66acc46...
Project: fides	Commit: 9a930b505c ℹ️
Status: Passed	Duration: 00:36 💡
Started: Mar 23, 2023 3:02 PM	Ended: Mar 23, 2023 3:03 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.13 ⚠️

Comparison is base (92a1191) 86.73% compared to head (971166b) 86.60%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2901      +/-   ##
==========================================
- Coverage   86.73%   86.60%   -0.13%     
==========================================
  Files         295      299       +4     
  Lines       16760    16814      +54     
  Branches     2146     2148       +2     
==========================================
+ Hits        14537    14562      +25     
- Misses       1821     1841      +20     
- Partials      402      411       +9     

Impacted Files	Coverage Δ
.../ops/service/messaging/message_dispatch_service.py	56.84% <0.00%> (ø)

... and 40 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[seanpreston]

@seanpreston my only concern is related to your question before about whether we have any non-html templates. can you think of anything that would make this a bit more robust/fail more obviously in the case that we do get a non-HTML template into our code base? maybe some automated test around that?

These are good questions. It's my understanding that if you pass text into html then that text still renders as text in the email that's sent, whereas if you pass HTML into the text attribute you get the HTML rendered as text. I'm just verifying.

[seanpreston]

Hey @adamsachs, I can confirm what I expected is the behaviour:

Both of those emails were sent using the html attribute, and the first contained only text.

[adamsachs]

Hey @adamsachs, I can confirm what I expected is the behaviour:

Both of those emails were sent using the html attribute, and the first contained only text.

Thank you for the diligence @seanpreston!!! great to see that we're able to get testing done internally too.

0 caveats or reservations on getting this merged now 😄