-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds System Manager (Data Steward) Endpoints [#2607] #2726
Adds System Manager (Data Steward) Endpoints [#2607] #2726
Conversation
…aces all the systems the user manages with those in the request body. - PUT /user/{user_id}/system-manager - GET /user/{user_id}/system-manager - GET /user/{user_id}/system-manager/{system_key} - DELETE /user/{user_id}/system-manager/{system_key} Adds new system manager scopes. Adds the read scopes to the viewer role.
Passing run #610 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
…m_manager_endpoints
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## fides_2609_add_system_managers_3 #2726 +/- ##
====================================================================
+ Coverage 86.69% 86.73% +0.04%
====================================================================
Files 293 293
Lines 16402 16454 +52
Branches 2078 2087 +9
====================================================================
+ Hits 14220 14272 +52
Misses 1795 1795
Partials 387 387
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…m_manager_endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩 🤩 🤩
SYSTEM_MANAGER_READ: "Read systems users can manager", | ||
SYSTEM_MANAGER_DELETE: "Delete systems user can manager", | ||
SYSTEM_MANAGER_UPDATE: "Update systems user can manager", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😸
SYSTEM_MANAGER_READ: "Read systems users can manager", | |
SYSTEM_MANAGER_DELETE: "Delete systems user can manager", | |
SYSTEM_MANAGER_UPDATE: "Update systems user can manager", | |
SYSTEM_MANAGER_READ: "Read systems users can manage", | |
SYSTEM_MANAGER_DELETE: "Delete systems user can manage", | |
SYSTEM_MANAGER_UPDATE: "Update systems user can manage", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah thank you!
…m_manager_endpoints
❗ Depends on #2609
Closes #2607
Code Changes
Update systems for which user is system manager.
Replaces all systems with systems in the request body. An empty list would remove a user as manager of all systems.
Get all systems for which user is system manager.
Get details about a single system a user manages
Remove user as system manager from a specific system.
Adds new system manager scopes.
Adds the read scopes to the viewer role.
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes