Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include feature flag check in helper #2675

Merged
merged 4 commits into from
Feb 23, 2023
Merged

include feature flag check in helper #2675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e999fcc
include feature flag check in helper
SteveDMurphy Feb 23, 2023
979dd22
changelog
SteveDMurphy Feb 23, 2023
a81fd09
combine nested if statements
SteveDMurphy Feb 23, 2023
03e7b51
remove extra bracket
SteveDMurphy Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,17 @@ The types of changes are:

* Add warning to 'fides deploy' when installed outside of a virtual environment [#2641](https://github.com/ethyca/fides/pull/2641)

### Fixed

* Fix error with the classify dataset feature flag not writing the dataset to the server [#2675](https://github.com/ethyca/fides/pull/2675)

## [2.7.0](https://github.com/ethyca/fides/compare/2.6.6...2.7.0)

* Fides API
* Access and erasure support for Braintree [#2223](https://github.com/ethyca/fides/pull/2223)
* Added route to send a test message [#2585](https://github.com/ethyca/fides/pull/2585)
* Add default storage configuration functionality and associated APIs [#2438](https://github.com/ethyca/fides/pull/2438)

* Admin UI
* Custom Metadata [#2536](https://github.com/ethyca/fides/pull/2536)
* Create Custom Lists
Expand Down Expand Up @@ -141,7 +145,7 @@ The types of changes are:
* Add a "skip_param_values option" to optionally skip when we are missing param values in the body [#2384](https://github.com/ethyca/fides/pull/2384)
* Adds a new Universal Analytics Connector that works with the UA Tracking Id
* Adds intake and storage of Global Privacy Control Signal props for Consent [#2599](https://github.com/ethyca/fides/pull/2599)

### Changed

* Unified Fides Resources
Expand All @@ -162,7 +166,7 @@ The types of changes are:

### Developer Experience

* `nox -s test_env` has been replaced with `nox -s "fides_env(dev)"`
* `nox -s test_env` has been replaced with `nox -s "fides_env(dev)"`
* New command `nox -s "fides_env(test)"` creates a complete test environment with seed data (similar to `fides_env(dev)`) but with the production fides image so the built UI can be accessed at `localhost:8080` [#2399](https://github.com/ethyca/fides/pull/2399)
* Change from code climate to codecov for coverage reporting [#2402](https://github.com/ethyca/fides/pull/2402)

Expand Down
2 changes: 1 addition & 1 deletion clients/admin-ui/src/features/dataset/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export const getUpdatedDatasetFromClassifyDataset = (
draftCollection.name
);

if (classifyCollection?.name !== activeCollection) {
if (activeCollection && classifyCollection?.name !== activeCollection) {
return;
}

Expand Down