Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pc/consent: Show GPC banner and how it affects individual consent choices #2596

Merged
merged 7 commits into from
Feb 16, 2023

Conversation

ssangervasi
Copy link
Contributor

@ssangervasi ssangervasi commented Feb 15, 2023

Closes #2230

Code Changes

  • pc/fides-consent: support globalPrivacyControl query param directly
    • Take a look at the screenshots below
  • pc/consent: Refactor consent local state into RTK store
  • pc/consent: helpers now only needs makeCookieKeyConsent
  • pc/package.json: Update fidesui dependencies to match admin-ui
    • The icons were out of date
  • pc/consent: Show GPC banner and how it affects individual consent choices
  • pc/consent: Cypress tests for GPC defaults and overrides in consent UI

Steps to Confirm

Pre-Merge Checklist

Description Of Changes

(These are a bit zoomed out so I could capture the URL and the whole page)

GPC enabled:
gpc-true

GPC disabled:
gpc-false

@ssangervasi ssangervasi force-pushed the ssangervasi/fides/2230/pc-gpc-ui branch 2 times, most recently from 97d48cb to 01bde7b Compare February 15, 2023 02:13
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 86.22% // Head: 86.22% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (37e37e0) compared to base (3dcde60).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2596   +/-   ##
=======================================
  Coverage   86.22%   86.22%           
=======================================
  Files         289      289           
  Lines       15780    15780           
  Branches     1985     1985           
=======================================
+ Hits        13606    13607    +1     
  Misses       1785     1785           
+ Partials      389      388    -1     
Impacted Files Coverage Δ
src/fides/api/ops/task/graph_task.py 94.48% <0.00%> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Feb 15, 2023

Passing run #180 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 37e37e0 into 3dcde60...
Project: fides Commit: a2d3ab1d70 ℹ️
Status: Passed Duration: 00:38 💡
Started: Feb 16, 2023 7:00 PM Ended: Feb 16, 2023 7:01 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ssangervasi ssangervasi force-pushed the ssangervasi/fides/2230/pc-gpc-ui branch from 01bde7b to 7ca3b9e Compare February 15, 2023 22:04
Copy link
Contributor

@LKCSmith LKCSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things, not blocking

@ssangervasi ssangervasi force-pushed the ssangervasi/fides/2230/pc-gpc-ui branch from 7ca3b9e to 37e37e0 Compare February 16, 2023 18:46
@ssangervasi ssangervasi merged commit cad3aeb into main Feb 16, 2023
@ssangervasi ssangervasi deleted the ssangervasi/fides/2230/pc-gpc-ui branch February 16, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflect GPC choices in the privacy center
2 participants