Switch mongo tests from randint to uuid #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #74 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Codecov ReportBase: 85.74% // Head: 85.74% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2591 +/- ##
=======================================
Coverage 85.74% 85.74%
=======================================
Files 285 285
Lines 15477 15477
Branches 1945 1945
=======================================
Hits 13270 13270
Misses 1832 1832
Partials 375 375 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ThomasLaPiana
approved these changes
Feb 15, 2023
|
In 3.8 of pymomgo there was a change to the ObjectID format and it has to be 12 bytes in a specific format https://www.mongodb.com/docs/manual/reference/method/ObjectId/. I bet this is the error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2178
Code Changes
randinttouuidin mongo testsSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdDescription Of Changes
The random int used in mongo tests is random, but not unique. The mongo tests don't clear out records between tests so by chance it is possible to have a clash in ids. This PR changes the use of random ints to using uuids. This is one of the causes mongo tests are flaky in CI, but I suspect it isn't the only reason so there is probably more to do here.