-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More form input types #2542
More form input types #2542
Conversation
Codecov ReportBase: 88.66% // Head: 85.73% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2542 +/- ##
==========================================
- Coverage 88.66% 85.73% -2.93%
==========================================
Files 331 285 -46
Lines 16099 15476 -623
Branches 4469 1945 -2524
==========================================
- Hits 14274 13269 -1005
- Misses 1668 1832 +164
- Partials 157 375 +218
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I value your Input
Passing run #43 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Failing test is unrelated |
Needed for #2435
The new designs have a new type of input that looks like
whereas our existing inputs look like
This PR adds a new
variant
prop to a few of the custom form fields that can either bestacked
orinline
in order to support both input types.Code Changes
stacked
andinline
variants. By splitting the components into subcomponents, it makes it easier to make the component return the same thing, just visually differentCustomSelect
andCustomMultiSelect
to be one component that takes anisMulti
optionSteps to Confirm
stacked
variant yet, and the forms default toinline
, so nothing should look different.Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Inline vs stacked CustomTextInput
Inline vs stacked CustomTextArea
Inline vs stacked CustomSelect