Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shippo Connector #2484

Merged
merged 8 commits into from
Apr 1, 2023
Merged

Shippo Connector #2484

merged 8 commits into from
Apr 1, 2023

Conversation

ctvivek
Copy link
Contributor

@ctvivek ctvivek commented Feb 2, 2023

Closes #1877

Code Changes

NEW SaaS Connector Shippo for access

Steps to Confirm

  • Add/configure the Shippo connector in UI
  • Verify Shippo config and icon UI looks good
  • Add customer data using Shippo UI (no api to add sales)
  • Create an Access DSR with the new Shippo customer email
  • Verify email sent by fides with customer data is correct

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

SaaS Connector Checklist

  • Spec doc link
  • Vault Creds
  • Postman Collection
  • SaaS Config And Dataset
  • Access Tests Passing
  • Icon

@ctvivek
Copy link
Contributor Author

ctvivek commented Mar 2, 2023

Screenshot from 2023-03-02 21-33-51

@ctvivek
Copy link
Contributor Author

ctvivek commented Mar 2, 2023

Screenshot from 2023-03-02 21-34-48

@ctvivek
Copy link
Contributor Author

ctvivek commented Mar 2, 2023

Screenshot from 2023-03-02 21-36-08

@Kelsey-Ethyca Kelsey-Ethyca changed the title shippo test Shippo Connector Mar 13, 2023
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, nice job on the dataset categories! The tests are passing but just make sure to make the recommended changes and we can wrap this up

@cypress
Copy link

cypress bot commented Apr 1, 2023

Passing run #1115 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge 4ad21ff into 716e2b1...
Project: fides Commit: 6acd673803 ℹ️
Status: Passed Duration: 00:50 💡
Started: Apr 1, 2023 12:33 AM Ended: Apr 1, 2023 12:33 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (716e2b1) 86.86% compared to head (4ad21ff) 86.86%.

❗ Current head 4ad21ff differs from pull request most recent head 6623d21. Consider uploading reports for the commit 6623d21 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2484      +/-   ##
==========================================
- Coverage   86.86%   86.86%   -0.01%     
==========================================
  Files         303      303              
  Lines       17177    17177              
  Branches     2195     2195              
==========================================
- Hits        14921    14920       -1     
  Misses       1844     1844              
- Partials      412      413       +1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galvana galvana merged commit b9fc855 into main Apr 1, 2023
@galvana galvana deleted the shippo-access-vivek branch April 1, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shippo
3 participants