-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gorgias Connector #2444
Gorgias Connector #2444
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2444 +/- ##
===========================================
+ Coverage 67.09% 87.52% +20.43%
===========================================
Files 313 309 -4
Lines 18241 17840 -401
Branches 2366 2310 -56
===========================================
+ Hits 12238 15614 +3376
+ Misses 5556 1802 -3754
+ Partials 447 424 -23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments on things that need to be cleaned up, let me know if you have any questions
Passing run #1529 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making all the recommended changes, good work on the test fixtures!
Closes #1947
Code Changes
NEW SaaS Connector Gorgias for access and erasure
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
SaaS Connector Checklist