Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gorgias Connector #2444

Merged
merged 22 commits into from
May 2, 2023
Merged

Gorgias Connector #2444

merged 22 commits into from
May 2, 2023

Conversation

tmuralikrishnan
Copy link
Contributor

@tmuralikrishnan tmuralikrishnan commented Jan 31, 2023

Closes #1947

Code Changes

NEW SaaS Connector Gorgias for access and erasure

Steps to Confirm

  • Add/configure the Gorgias connector in UI
  • Verify Gorgias config and icon UI looks good
  • Add customer data using Gorgias API
  • Create an Access DSR with the new Gorgias customer email
  • Verify email sent by fides with customer data is correct
  • Create an Delete DSR with the new Gorgias customer email
  • Verify the customer data is now deleted in Gorgias

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

SaaS Connector Checklist

  • Spec doc link
  • Vault Creds
  • Postman Collection
  • SaaS Config And Dataset
  • Access and Erasure Tests Passing
  • Icon

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +20.43 🎉

Comparison is base (7eeb2de) 67.09% compared to head (bb850bf) 87.52%.

❗ Current head bb850bf differs from pull request most recent head 66f23ac. Consider uploading reports for the commit 66f23ac to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2444       +/-   ##
===========================================
+ Coverage   67.09%   87.52%   +20.43%     
===========================================
  Files         313      309        -4     
  Lines       18241    17840      -401     
  Branches     2366     2310       -56     
===========================================
+ Hits        12238    15614     +3376     
+ Misses       5556     1802     -3754     
+ Partials      447      424       -23     

see 160 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tmuralikrishnan
Copy link
Contributor Author

Screenshot from 2023-03-01 15-35-30

@tmuralikrishnan
Copy link
Contributor Author

image

@tmuralikrishnan
Copy link
Contributor Author

image

@Kelsey-Ethyca Kelsey-Ethyca changed the title gorgias access request test Gorgias Connector Mar 13, 2023
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments on things that need to be cleaned up, let me know if you have any questions

@cypress
Copy link

cypress bot commented Apr 8, 2023

Passing run #1529 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge bb850bf into 8b01ab9...
Project: fides Commit: 32bef6c75a ℹ️
Status: Passed Duration: 00:35 💡
Started: Apr 24, 2023 4:37 PM Ended: Apr 24, 2023 4:37 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@galvana galvana self-requested a review April 26, 2023 22:50
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all the recommended changes, good work on the test fixtures!

@galvana galvana merged commit 1aa3219 into main May 2, 2023
@galvana galvana deleted the gorgias-access-muralikrishnan branch May 2, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gorgias
3 participants