-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy request approval modal #2443
Conversation
Codecov ReportBase: 88.55% // Head: 88.55% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2443 +/- ##
=======================================
Coverage 88.55% 88.55%
=======================================
Files 327 327
Lines 15714 15714
Branches 4348 4348
=======================================
Hits 13915 13915
Misses 1644 1644
Partials 155 155 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @TheAndrewJackson
Closes #2289 Closes #2291
Code Changes
ConfirmationModal
so it's able to be reused as the approval modal.ApprovePrivacyRequestModal
componentRequestRow
to handle newApprovePrivacyRequestModal
componentSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Adds new approval modal and disables the approve/deny buttons in the background while a request is happening.
Screen.Recording.2023-01-31.at.12.04.58.mov