Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy request approval modal #2443

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Jan 31, 2023

Closes #2289 Closes #2291

Code Changes

  • Update ConfirmationModal so it's able to be reused as the approval modal.
  • Add ApprovePrivacyRequestModal component
  • Update RequestRow to handle new ApprovePrivacyRequestModal component

Steps to Confirm

  • Run fides and create some privacy requests.
  • Approve them and observe the new modal
  • Try throttling network activity to slow 3G. This will make it easier to test the loading spinners and the disabled approve/deny buttons in the background

Pre-Merge Checklist

Description Of Changes

Adds new approval modal and disables the approve/deny buttons in the background while a request is happening.

Screen.Recording.2023-01-31.at.12.04.58.mov

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 88.55% // Head: 88.55% // No change to project coverage 👍

Coverage data is based on head (875437b) compared to base (502d689).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2443   +/-   ##
=======================================
  Coverage   88.55%   88.55%           
=======================================
  Files         327      327           
  Lines       15714    15714           
  Branches     4348     4348           
=======================================
  Hits        13915    13915           
  Misses       1644     1644           
  Partials      155      155           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheAndrewJackson TheAndrewJackson changed the title Bugfix 2291 privacy request approval modal Privacy request approval modal Jan 31, 2023
@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review January 31, 2023 17:10
@TheAndrewJackson TheAndrewJackson self-assigned this Feb 1, 2023
Copy link
Contributor

@seanpreston seanpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @TheAndrewJackson

@seanpreston seanpreston merged commit 32065f3 into main Feb 1, 2023
@seanpreston seanpreston deleted the bugfix_2291_privacy_request_approval_modal branch February 1, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants