Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1874 saas connector friendbuy #2019

Merged
merged 7 commits into from
Dec 20, 2022
Merged

1874 saas connector friendbuy #2019

merged 7 commits into from
Dec 20, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 9, 2022

Purpose

  • Purpose of this PR is to add Friendbuy connector access and erasure endpoints

Changes

  • Added config for Friendbuy Access and Erasure Endpoints
  • Added related dataset and configuration
  • Added associated tests to validate above functionality

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1874

@ghost ghost requested review from galvana and a team December 9, 2022 20:55
@galvana galvana removed the request for review from a team December 16, 2022 21:42
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we're only dealing with the customer endpoint this is perfect, but I would like to discuss why other endpoints weren't covered as part of this connector, let's discuss offline.

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hamza and I reviewed Friendbuy's data request endpoint and it only returns a count of different objects so we're omitting the purchases endpoint for now

@galvana galvana merged commit 9e26c7e into main Dec 20, 2022
@galvana galvana deleted the 1874-saas-connector-friendbuy branch December 20, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FriendBuy
1 participant