Fix EditDrawer styling and move save/cancel buttons to DrawerFooter #1803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been bothering me for a while and I've finally leveled up enough to fix it 😅
The EditDrawers always had weird styling that I was only able to get around by using
vh
. This caused some inconsistency though and made some elements cut off unexpectedly at times.In addition, it was annoying that the Cancel/Save buttons were not included in the
EditDrawer
wrapper. This was mostly because I thought the "submit" buttons had to be inside a<form>
element. It turns out you can just associate a submit button with a form via ID though and it'll figure itself out regardless of hierarchy 🎉Code Changes
vh
workaroundsSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats