Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EditDrawer styling and move save/cancel buttons to DrawerFooter #1803

Merged
merged 3 commits into from
Nov 18, 2022

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Nov 16, 2022

This has been bothering me for a while and I've finally leveled up enough to fix it 😅

The EditDrawers always had weird styling that I was only able to get around by using vh. This caused some inconsistency though and made some elements cut off unexpectedly at times.

In addition, it was annoying that the Cancel/Save buttons were not included in the EditDrawer wrapper. This was mostly because I thought the "submit" buttons had to be inside a <form> element. It turns out you can just associate a submit button with a form via ID though and it'll figure itself out regardless of hierarchy 🎉

Code Changes

  • Fix styling error by removing an unneeded Box component
  • Remove styling vh workarounds
  • Move cancel/edit buttons into EditDrawer

Steps to Confirm

  • Try editing a dataset, field, or collection. Things should work the same

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

@allisonking allisonking marked this pull request as ready for review November 17, 2022 14:13
Copy link
Contributor

@LKCSmith LKCSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@ssangervasi ssangervasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workin 👍

@allisonking allisonking merged commit e4bb7bb into main Nov 18, 2022
@allisonking allisonking deleted the aking/fix-drawers branch November 18, 2022 17:00
@ssangervasi ssangervasi mentioned this pull request Nov 19, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants