Fix cypress auth test and test debugging improvements

.github/workflows/frontend_checks.yml

@@ -17,7 +17,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [ 16.x ]
+        node-version: [16.x]
     defaults:
       run:
         working-directory: clients/admin-ui
@@ -73,6 +73,12 @@ jobs:
           wait-on: "http://localhost:3000"
           wait-on-timeout: 120
 
+      - uses: actions/upload-artifact@v3
+        if: failure()
+        with:
+          name: cypress-videos
+          path: /home/runner/work/fides/fides/clients/admin-ui/cypress/videos/*.mp4
+
   Privacy-Center-Unit:
     runs-on: ubuntu-latest
     strategy:

clients/admin-ui/.env.test

@@ -0,0 +1,3 @@
+NEXT_PUBLIC_FIDESOPS_API=http://0.0.0.0:8080
+NEXT_PUBLIC_FIDESCTL_API=/api/v1
+NEXT_PUBLIC_FIDESCTL_API_SERVER=http://0.0.0.0:8080

clients/admin-ui/.gitignore

@@ -68,10 +68,11 @@ typings/
 # Yarn Integrity file
 .yarn-integrity
 
-# dotenv environment variables file
-.env
-.env.test
-.env.local
+# Only the dev, test, and prod defaults are tracked.
+.env*
+!.env.development
+!.env.test
+!.env.production
 
 # parcel-bundler cache (https://parceljs.org/)
 .cache
@@ -108,5 +109,4 @@ dist
 # msw web worker script
 public/mockServiceWorker.js
 
-
-out/
+out/

clients/admin-ui/cypress/e2e/auth.cy.ts

@@ -61,6 +61,10 @@ describe("User Authentication", () => {
       cy.visit("/system");
       cy.getByTestId("Systems");
 
+      cy.intercept("POST", "/api/v1/logout", {
+        statusCode: 204,
+      });
+
       cy.getByTestId("header-menu-button").click();
       cy.getByTestId("header-menu-sign-out").click();
 

clients/admin-ui/cypress/e2e/datasets-classify.cy.ts

@@ -22,11 +22,12 @@ describe("Datasets with Fides Classify", () => {
     cy.intercept("GET", "/api/v1/plus/classify", {
       fixture: "classify/list.json",
     }).as("getClassifyList");
+    cy.visit("/dataset/new");
+    cy.wait("@getPlusHealth");
   });
 
   describe("Creating datasets", () => {
     it("Shows the classify switch", () => {
-      cy.visit("/dataset/new");
       cy.getByTestId("connect-db-btn").click();
 
       cy.getByTestId("input-classify").find("input").should("be.checked");
@@ -36,7 +37,6 @@ describe("Datasets with Fides Classify", () => {
 
     it("Classifies the dataset after generating it", () => {
       // Fill out the form.
-      cy.visit("/dataset/new");
       cy.getByTestId("connect-db-btn").click();
       cy.getByTestId("input-url").type(CONNECTION_STRING);
       cy.getByTestId("create-dataset-btn").click();
@@ -192,10 +192,7 @@ describe("Datasets with Fides Classify", () => {
         }
       );
 
-      cy.getByTestId("approve-classification-btn")
-        .should("be.enabled")
-        .click()
-        .should("be.disabled");
+      cy.getByTestId("approve-classification-btn").should("be.enabled").click();
 
       // The mutations should run.
       cy.wait("@putDataset");

clients/admin-ui/next.config.js

@@ -21,6 +21,12 @@ const nextConfig = {
         return config;
     },
     async rewrites() {
+        // The tests run without a server. Rewrites cause Next to continually try to connect,
+        // which spams the logs with "ECONNREFUSED".
+        if (process.env.NODE_ENV === "test") {
+            return [];
+        }
+
         // these paths are unnecessarily complicated due to our backend being
         // picky about trailing slashes https://github.com/ethyca/fides/issues/690
         return [

clients/admin-ui/package.json

@@ -10,7 +10,7 @@
     "copy-export": "mkdir -p ../../src/fides/ui-build/static/admin/ && rsync -a --delete out/ ../../src/fides/ui-build/static/admin/",
     "cy:open": "cypress open",
     "cy:run": "cypress run",
-    "cy:start": "next build && NODE_ENV=test next start",
+    "cy:start": "NODE_ENV=test next build && NODE_ENV=test next start",
     "dev": "next dev",
     "dev:mock": "echo '🚨 Running with mock API'; NEXT_PUBLIC_MOCK_API=true next dev",
     "export": "next build && next export",