Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1184 allow delete only saas endpoints #1420

Merged
merged 9 commits into from
Oct 13, 2022
Merged

1184 allow delete only saas endpoints #1420

merged 9 commits into from
Oct 13, 2022

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Oct 12, 2022

Adding commit that was missed as part of #1200

@galvana galvana requested a review from a team October 12, 2022 21:21
@galvana galvana mentioned this pull request Oct 12, 2022
Merged
7 tasks
@galvana galvana added run unsafe ci checks Runs fides-related CI checks that require sensitive credentials and removed run unsafe ci checks Runs fides-related CI checks that require sensitive credentials labels Oct 12, 2022
adamsachs
adamsachs approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all seems good to me!

@galvana galvana added run unsafe ci checks Runs fides-related CI checks that require sensitive credentials and removed run unsafe ci checks Runs fides-related CI checks that require sensitive credentials labels Oct 13, 2022
@galvana galvana merged commit 8af7c06 into main Oct 13, 2022
@galvana galvana deleted the 1184-allow-delete-only-saas-endpoints branch October 13, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsachs adamsachs adamsachs approved these changes

@pattisdr pattisdr Awaiting requested review from pattisdr

Assignees
No one assigned
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galvana @adamsachs