From 5304d08562842050beb1de9b222f489b871931c7 Mon Sep 17 00:00:00 2001 From: Thomas Date: Mon, 12 Sep 2022 02:27:38 -0700 Subject: [PATCH 1/4] Update NavBar.tsx --- clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx b/clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx index 8ccc6fbc2e..88425343dd 100644 --- a/clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx +++ b/clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx @@ -27,9 +27,7 @@ const NavBar = () => { {/* Links under the datamap zone: */} {features.plus ? : null} - - {/* This is a temporary link to the config wizard while it's still in progress */} Date: Mon, 12 Sep 2022 21:23:14 +0800 Subject: [PATCH 2/4] remove "more" from the navbar --- clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx | 6 ------ 1 file changed, 6 deletions(-) diff --git a/clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx b/clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx index 88425343dd..0db6d203dd 100644 --- a/clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx +++ b/clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx @@ -30,12 +30,6 @@ const NavBar = () => { {/* This is a temporary link to the config wizard while it's still in progress */} - } - disabled - /> ); From 338d989c46a8f13d8ad7c677b699ccfa11dd38bb Mon Sep 17 00:00:00 2001 From: Thomas Date: Mon, 12 Sep 2022 21:27:01 +0800 Subject: [PATCH 3/4] fix a linting error --- clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx b/clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx index 0db6d203dd..da778c5675 100644 --- a/clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx +++ b/clients/ctl/admin-ui/src/features/common/nav/NavBar.tsx @@ -3,7 +3,6 @@ import dynamic from "next/dynamic"; import React from "react"; import { useFeatures } from "~/features/common/features.slice"; -import { ArrowDownLineIcon } from "~/features/common/Icon"; // Cross-zone navigation requires building URLs from the current `window.location` // which is not available in Server-Side-Rendered components. From 7c65c604bb49979d11dcdbf4b445c0be875e1dbd Mon Sep 17 00:00:00 2001 From: Thomas Date: Mon, 12 Sep 2022 22:46:44 +0800 Subject: [PATCH 4/4] remove cypress tests for disabled links --- clients/ctl/admin-ui/cypress/e2e/nav-bar.cy.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/clients/ctl/admin-ui/cypress/e2e/nav-bar.cy.ts b/clients/ctl/admin-ui/cypress/e2e/nav-bar.cy.ts index 08bfba8d1b..72d93f19bb 100644 --- a/clients/ctl/admin-ui/cypress/e2e/nav-bar.cy.ts +++ b/clients/ctl/admin-ui/cypress/e2e/nav-bar.cy.ts @@ -7,11 +7,6 @@ describe("Nav Bar", () => { cy.getByTestId("nav-link-Taxonomy"); cy.getByTestId("nav-link-Systems"); - // Disabled links - - cy.getByTestId("nav-link-Policies").should("have.attr", "disabled"); - cy.getByTestId("nav-link-User Management").should("have.attr", "disabled"); - cy.getByTestId("nav-link-More").should("have.attr", "disabled"); }); it("Renders the active page based on the current route", () => {