Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fides push --diff always shows a diff, even if the object hasn't actually changed #985

Closed
ThomasLaPiana opened this issue Aug 15, 2022 · 0 comments · Fixed by #1026
Closed
Assignees
Labels
bug Something isn't working

Comments

@ThomasLaPiana
Copy link
Contributor

ThomasLaPiana commented Aug 15, 2022

Bug Description

Diff is returning false positive changes

Steps to Reproduce

  1. fides push --diff
  2. fides push --diff but notice that the system object thinks there have been a change

Expected behavior

Double pushing should show no diff!

Additional context

This is related to the diffing algorithm, and the fact that it specifically isn't handling complex objects correctly. On potential solution would be to convert both objects into their proper fideslang models, and then back to a dict for comparison?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants