Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate all endpoints to have /api/v1 prefix #623

Closed
allisonking opened this issue May 9, 2022 · 1 comment · Fixed by #635
Closed

Migrate all endpoints to have /api/v1 prefix #623

allisonking opened this issue May 9, 2022 · 1 comment · Fixed by #635
Assignees
@allisonking
Milestone
1.7.0

Comments

@allisonking
Copy link
Contributor

allisonking commented May 9, 2022 •
edited
Loading

Is your feature request related to a specific problem?

Now that we will have a frontend app, we should prefix all of our API endpoints with /api so that the backend and frontend routes don't clash.

Describe the solution you'd like

Prefix all of our backend API's with /api. That will also allow #621 to be a little smarter about which paths to 404 vs which paths to just reroute to the frontend home page (status quo is to reroute everyone to the home page since there is no easy way to say what is a backend endpoint vs a frontend route)

Describe alternatives you've considered, if any

Could do nothing, or serve frontend at a specific path, but that would make the user facing URL weird

Additional context

See #560 (comment)
@allisonking allisonking changed the title Migrate all endpoint to have /api prefix Migrate all endpoints to have /api prefix May 9, 2022
@allisonking allisonking added this to the 1.7.0 milestone May 9, 2022
@NevilleS
Copy link
Contributor

NevilleS commented May 9, 2022 •
edited
Loading

Good point! I'd vote for /api/v1 specifically, to match the URI structure of fidesops

@allisonking allisonking changed the title Migrate all endpoints to have /api prefix Migrate all endpoints to have /api/v1 prefix May 10, 2022
@allisonking allisonking self-assigned this May 11, 2022
@allisonking allisonking mentioned this issue May 11, 2022
Merged
9 tasks
ThomasLaPiana pushed a commit that referenced this issue Aug 17, 2022
@PSalant726
Bring main up to date with v1.5.3 (#628)
2b41ee1 
* Move the `migrations` package into the `fidesops` package (#620)

* Move `/migrations` into core fidesops package

Also moves the `alembic.ini` file.

* Update references to the `/migrations` dir

* Remove unused `PackageSettings`

* Update `CHANGELOG.md`

* Correct the path to `alembic.ini`

* Correctly resolve config paths

* Update `CHANGELOG.md` for patch release 1.5.3 (#623)

* move migration

Co-authored-by: Phil Salant <[email protected]>
ThomasLaPiana pushed a commit that referenced this issue Sep 26, 2022
@PSalant726
Bring main up to date with v1.5.3 (#628)
f782485 
* Move the `migrations` package into the `fidesops` package (#620)

* Move `/migrations` into core fidesops package

Also moves the `alembic.ini` file.

* Update references to the `/migrations` dir

* Remove unused `PackageSettings`

* Update `CHANGELOG.md`

* Correct the path to `alembic.ini`

* Correctly resolve config paths

* Update `CHANGELOG.md` for patch release 1.5.3 (#623)

* move migration

Co-authored-by: Phil Salant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allisonking allisonking

Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Prefix API endpoints with /api/v1 ethyca/fides
2 participants
@NevilleS @allisonking