Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fideslang module in favor of fideslang package #619

Merged
merged 2 commits into from
May 9, 2022
Merged

Remove fideslang module in favor of fideslang package #619

merged 2 commits into from
May 9, 2022

Conversation

earmenda
Copy link
Contributor

@earmenda earmenda commented May 9, 2022 •
edited
Loading

Closes #524

Code Changes

  • Remove fideslang module
  • Move hydrate_missing_resources function into fidesctl module
  • Reorganize imports to appease pylint
  • Remove/move corresponding tests

Steps to Confirm

  • Manual testing of cli commands
  • All tests still pass with usage of fideslang external module

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Moved to using new fideslang project from pypi build https://github.com/ethyca/fideslang

@earmenda earmenda self-assigned this May 9, 2022
@earmenda earmenda added this to the 1.7.0 milestone May 9, 2022
@earmenda earmenda marked this pull request as ready for review May 9, 2022 08:23
@earmenda earmenda requested a review from a team May 9, 2022 08:23
ThomasLaPiana
ThomasLaPiana approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@earmenda earmenda merged commit e2cfd00 into main May 9, 2022
@earmenda earmenda deleted the earmenda-fideslang-package-migration branch May 9, 2022 21:27
ThomasLaPiana pushed a commit that referenced this pull request Aug 17, 2022
@galvana
[SaaS Connector] Outreach (Erasures) (#619)
bc6ad23
ThomasLaPiana pushed a commit that referenced this pull request Sep 26, 2022
@galvana
[SaaS Connector] Outreach (Erasures) (#619)
e1e8f94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasLaPiana ThomasLaPiana ThomasLaPiana approved these changes

Assignees

@earmenda earmenda

Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Remove fideslang code, instead importing from fideslang via pip
2 participants
@earmenda @ThomasLaPiana