Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fides.css to vary width based on tcf #4381

Merged
merged 8 commits into from
Nov 3, 2023

Conversation

Kelsey-Ethyca
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca commented Nov 3, 2023

Closes PROD-1316

Description Of Changes

Update fides.css; tcf banner will be full width and non-tcf will be no greater than 75% width

Steps to Confirm

Pre-Merge Checklist

UAT

Screen.Recording.2023-11-03.at.10.06.37.AM.mov

@Kelsey-Ethyca Kelsey-Ethyca changed the title Update fides css to vary banner width based on tcf enabled or disabled Update fides.css to vary width based on tcf Nov 3, 2023
Copy link

cypress bot commented Nov 3, 2023

Passing run #5018 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge f9b32c3 into 2d0d7e4...
Project: fides Commit: 3a946862c3 ℹ️
Status: Passed Duration: 00:55 💡
Started: Nov 3, 2023 8:54 PM Ended: Nov 3, 2023 8:55 PM

Review all test suite changes for PR #4381 ↗︎

@galvana galvana self-requested a review November 3, 2023 17:33
@galvana
Copy link
Contributor

galvana commented Nov 3, 2023

I noticed two issues, the consent banner has padding on the right and bottom from overflow: scroll instead of overflow:auto
image

Also, the footer on the TCF banner is no longer fixed
image

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the original issue but there are some regressions in the consent/TCF modals

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the regressions, looks good to me!

@Kelsey-Ethyca
Copy link
Contributor Author

Kelsey-Ethyca commented Nov 3, 2023

UAT with Adrian

  • TCF banner not embedded
  • TCF banner embedded
  • TCF modal not embedded
  • TCF modal embedded
  • notice (non TCF) banner not embedded
  • notice banner embedded
  • notice modal not embedded
  • notice modal embedded
Screen.Recording.2023-11-03.at.12.59.56.PM.mov

@Kelsey-Ethyca Kelsey-Ethyca merged commit 56dbaa5 into main Nov 3, 2023
11 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the update-fides-css-vary-banner-width branch November 3, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants