Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only list vendors in the data map as vendors_disclosed in the FE #4165

Closed
allisonking opened this issue Sep 26, 2023 · 3 comments · Fixed by #4250
Closed

Only list vendors in the data map as vendors_disclosed in the FE #4165

allisonking opened this issue Sep 26, 2023 · 3 comments · Fixed by #4250
Assignees
Labels
bug Something isn't working

Comments

@allisonking
Copy link
Contributor

Bug Description

After another reread of the spec, we think it makes sense to only list the vendors in both the datamap and the GVL in the vendors_disclosed section of the TC string. See the discussion here: #4160 (comment)

The backend has gone ahead and made this change, so we should do something similar for the FE!

Steps to Reproduce

  1. Set up your TCF environment
  2. Opt in or opt out of all
  3. Check your TC string—it'll have a huge vendors disclosed section since it lists every vendor in the GVL when it should really only list the vendors we are showing in the vendor tab.

Expected behavior

The vendors disclosed section should only show the vendors in the vendor tab.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

  • Version:
  • OS:
  • Python Version:
  • Docker Version:

Additional context

Add any other context about the problem here.

@allisonking allisonking added the bug Something isn't working label Sep 26, 2023
@allisonking allisonking self-assigned this Sep 26, 2023
@allisonking
Copy link
Contributor Author

Actually, it looks like we should not be including this string at all when the CMP API surfaces it
🤔 https://ethyca.slack.com/archives/C05E74TR0BB/p1696341554803559

@allisonking
Copy link
Contributor Author

allisonking commented Oct 9, 2023

digging into the iab-tcf library some more, it looks like there is a requirement for when isServiceSpecific is false, to set all vendorsDisclosed https://github.com/InteractiveAdvertisingBureau/iabtcf-es/blob/0b1e3a6875b6e1dbff25845cb4ec83f5cc9c7264/modules/core/test/TCString.test.ts#L60

EDIT: actually, we set isServiceSpecific to true, so that shouldn't affect it...

@allisonking
Copy link
Contributor Author

Okay we no longer surface the vendors_disclosed string as part of the CMP API: https://github.com/ethyca/fides/pull/4244/files

However, I am still confused about how to actually properly set the vendors_disclosed string, as the library seems to insist that we set all the GVL vendors. more investigation needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant