Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Map Excluding Systems Without Privacy Declarations #1414

Closed
SteveDMurphy opened this issue Oct 12, 2022 · 2 comments · Fixed by #1603
Closed

Data Map Excluding Systems Without Privacy Declarations #1414

SteveDMurphy opened this issue Oct 12, 2022 · 2 comments · Fixed by #1603
Assignees
Labels
bug Something isn't working

Comments

@SteveDMurphy
Copy link
Contributor

SteveDMurphy commented Oct 12, 2022

Bug Description

If my System is not annotated with a privacy declaration, it is excluded from my datamap. I expect all of my available systems to be found on my datamap, regardless of their state of compliance (i.e. privacy declarations)

Steps to Reproduce

  1. Create a System that does not have a privacy declaration
  2. Export your data map (no system)
  3. Add a privacy declaration
  4. Export data map again (system is visible)

Expected behavior

My datamap should contain all available resources, regardless of completeness. This is critical to being able to manage compliance via the datamap

Screenshots

n/a

Environment

  • Version: 1.9.2
  • OS: Darwin
  • Python Version: 3.9.13
  • Docker Version: 20.10.17

Additional context

Originally discovered by @allisonking

To be able to test this, adding a system like the following should work (note the [] under privacy_declarations, this is because None is not allowed):

system:
  # System Info
  - fides_key: fake_system
    name: fake system
    organization_fides_key: default_organization
    system_type: Service
    privacy_declarations: []

The main focus area to resolve this discrepancy I think should like in how we are initially exporting records for a system - having default values (or similar) should allow for the system to propagate to the exported data

@SteveDMurphy SteveDMurphy added the bug Something isn't working label Oct 12, 2022
@seanpreston
Copy link
Contributor

@SteveDMurphy could you please leave some implementation instructions here so we can have someone else hit this?

@seanpreston seanpreston self-assigned this Oct 18, 2022
@SteveDMurphy
Copy link
Contributor Author

@SteveDMurphy could you please leave some implementation instructions here so we can have someone else hit this?

Added some context to the Description under Additional Context - I believe focusing on the early subset of records should be sufficient however some more work may be required to ensure the records appear as part of the datamap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants