Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placeholder - refactor front end to remove SaaSType enum #1235

Closed
adamsachs opened this issue Oct 5, 2022 · 1 comment
Closed

placeholder - refactor front end to remove SaaSType enum #1235

adamsachs opened this issue Oct 5, 2022 · 1 comment

Comments

@adamsachs
Copy link
Contributor

adamsachs commented Oct 5, 2022

Is your feature request related to a specific problem?

With #1197, we removed the SaaSType enum from the backend, and made the type field on SaaS configs fully dynamic. The frontend still contains a static SaaSType enum that should be removed to reflect the dynamic nature of SaaS config types accordingly. According to @chriscalhoun1974 , there's some nontrivial refactoring work that needs to be done on the frontend codebase to make this possible. This issue is a general placeholder to account for that work so that we don't lose track of it - more specific issues can be created as the refactoring work is better defined.

#1230 and #1231 are backend features that are likely needed in order to make this frontend refactoring possible.

@chriscalhoun1974 please feel free to update this as you see fit!

Describe the solution you'd like

A description of what you want to happen.

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

@galvana
Copy link
Contributor

galvana commented Apr 12, 2023

Removed as part of #3018

@galvana galvana closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants