From d763c71d220671b83c10d5b036b2c873448c9e06 Mon Sep 17 00:00:00 2001
From: Adrian Galvan <adrian@ethyca.com>
Date: Mon, 27 Mar 2023 08:41:45 -0700
Subject: [PATCH] Removing payment_types connector param (#2915)

---
 CHANGELOG.md                                         | 3 ++-
 data/saas/config/stripe_config.yml                   | 8 ++------
 tests/ops/integration_tests/saas/test_stripe_task.py | 4 +---
 3 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 97b8b3e387..5bd75d3b1c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -33,7 +33,8 @@ The types of changes are:
 * Changed About Fides page to say "Fides Core Version:" over "Version". [#2899](https://github.com/ethyca/fides/pull/2899)
 * Polish Admin UI header & navigation [#2897](https://github.com/ethyca/fides/pull/2897)
 * Give new users a "viewer" role by default [#2900](https://github.com/ethyca/fides/pull/2900)
-* Tie together save states for user permissions and systems [2913](https://github.com/ethyca/fides/pull/2913)
+* Tie together save states for user permissions and systems [#2913](https://github.com/ethyca/fides/pull/2913)
+* Removing payment types from Stripe connector params [#2915](https://github.com/ethyca/fides/pull/2915)
 
 
 ### Fixed
diff --git a/data/saas/config/stripe_config.yml b/data/saas/config/stripe_config.yml
index d7617ae081..5a57e2c068 100644
--- a/data/saas/config/stripe_config.yml
+++ b/data/saas/config/stripe_config.yml
@@ -3,13 +3,12 @@ saas_config:
   name: Stripe
   type: stripe
   description: A sample schema representing the Stripe connector for Fides
-  version: 0.0.2
+  version: 0.0.3
 
   connector_params:
     - name: domain
       default_value: api.stripe.com
     - name: api_key
-    - name: payment_types
 
   client_config:
     protocol: https
@@ -141,8 +140,6 @@ saas_config:
           method: GET
           path: /v1/customers/<customer_id>/payment_methods
           query_params:
-            - name: type
-              value: <type>
             - name: limit
               value: 100
           param_values:
@@ -151,8 +148,6 @@ saas_config:
                 - dataset: <instance_fides_key>
                   field: customer.id
                   direction: from
-            - name: type
-              connector_param: payment_types
           data_path: data
           pagination:
             strategy: cursor
@@ -161,6 +156,7 @@ saas_config:
               field: id
         update:
           method: POST
+          ignore_errors: true # payment methods of type us_bank_account cannot be updated at this time.
           path: /v1/payment_methods/<payment_method_id>
           headers:
             - name: Content-Type
diff --git a/tests/ops/integration_tests/saas/test_stripe_task.py b/tests/ops/integration_tests/saas/test_stripe_task.py
index 8a9cc5aadb..587dbd21ab 100644
--- a/tests/ops/integration_tests/saas/test_stripe_task.py
+++ b/tests/ops/integration_tests/saas/test_stripe_task.py
@@ -394,7 +394,6 @@ async def test_stripe_access_request_task_with_email(
         min_size=2,
         keys=[
             "billing_details",
-            "card",
             "created",
             "customer",
             "id",
@@ -1080,7 +1079,6 @@ async def test_stripe_erasure_request_task(
         min_size=2,
         keys=[
             "billing_details",
-            "card",
             "created",
             "customer",
             "id",
@@ -1172,7 +1170,7 @@ async def test_stripe_erasure_request_task(
         f"{dataset_name}:card": 1,
         f"{dataset_name}:customer_balance_transaction": 0,
         f"{dataset_name}:payment_intent": 0,
-        f"{dataset_name}:payment_method": 2,
+        f"{dataset_name}:payment_method": 3,
         f"{dataset_name}:credit_note": 0,
         f"{dataset_name}:bank_account": 1,
         f"{dataset_name}:subscription": 1,