Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test would fail with "EthStorageContract2: invalid samples" #323

Closed
ping-ke opened this issue Oct 22, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@ping-ke
Copy link
Collaborator

ping-ke commented Oct 22, 2024

System information

EthStorage node version: es-node version
Build date: e.g. Tue 12 Dec 2023 04:20:27 AM EST
System version: e.g. amd64/Linux
Golang version: e.g. go1.20
Commit hash : (if develop)

Expected behavior

The integration test is mining during uploading blobs, so the blob may be empty when the sampling happens, and filled before the TX submitted. At this time, the TX will fail with "EthStorageContract2: invalid samples" which is by design. and we should not treat it as mining failure and increase the s.Failed counter. but treat it as TX drop and increase s.Dropped counter.
1729563215961

Actual behavior

The mining TX fails with "EthStorageContract2: invalid samples" will increase s.Failed counter, which causes the integration test to fail.

@ping-ke ping-ke added the bug Something isn't working label Oct 22, 2024
@ping-ke ping-ke self-assigned this Oct 22, 2024
@ping-ke
Copy link
Collaborator Author

ping-ke commented Nov 5, 2024

#326 resolve this issue.
close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant