You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
EthStorage node version: es-node version
Build date: e.g. Tue 12 Dec 2023 04:20:27 AM EST
System version: e.g. amd64/Linux
Golang version: e.g. go1.20
Commit hash : (if develop)
Expected behavior
The integration test is mining during uploading blobs, so the blob may be empty when the sampling happens, and filled before the TX submitted. At this time, the TX will fail with "EthStorageContract2: invalid samples" which is by design. and we should not treat it as mining failure and increase the s.Failed counter. but treat it as TX drop and increase s.Dropped counter.
Actual behavior
The mining TX fails with "EthStorageContract2: invalid samples" will increase s.Failed counter, which causes the integration test to fail.
The text was updated successfully, but these errors were encountered:
System information
EthStorage node version:
es-node version
Build date: e.g. Tue 12 Dec 2023 04:20:27 AM EST
System version: e.g. amd64/Linux
Golang version: e.g. go1.20
Commit hash : (if
develop
)Expected behavior
The integration test is mining during uploading blobs, so the blob may be empty when the sampling happens, and filled before the TX submitted. At this time, the TX will fail with "EthStorageContract2: invalid samples" which is by design. and we should not treat it as mining failure and increase the s.Failed counter. but treat it as TX drop and increase s.Dropped counter.
Actual behavior
The mining TX fails with "EthStorageContract2: invalid samples" will increase s.Failed counter, which causes the integration test to fail.
The text was updated successfully, but these errors were encountered: