feat: add vero vc_type
#827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice PR, seems to be working as described. Few nitpicks, could you modify the grafana dash to show the name (job/service) of the container instead of the instance which is IP:, and possibly have an option to enable overview of all validator processes at the same time. |
|
Grafana dashboard modified to show the proper name/job.
This is not too easy to adjust in this dashboard, it's really quite instance-specific. |
parithosh
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Vero validator client as a supported
vc_type.The Vero VC doesn't handle keys and requires a remote signer to be used (
use_remote_signer: true). It can handle the minimal preset, as well as customseconds_per_slotvalues.I've added the "Vero - Detailed" Grafana dashboard. I'm not sure if it's a good fit for this repo, let me know if you'd like me to remove it.