Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing double quote on the latest PR #177

Open
nickkounz opened this issue Jan 29, 2025 · 2 comments
Open

missing double quote on the latest PR #177

nickkounz opened this issue Jan 29, 2025 · 2 comments

Comments

@nickkounz
Copy link

nickkounz commented Jan 29, 2025

The recent PR you merged is missing double quote on it.

Image

It supposed to be like below

export EIP7732_FORK_VERSION="${EIP7732_FORK_VERSION:-0x80000000}"
export EIP7732_FORK_EPOCH="${EIP7732_FORK_EPOCH:-99999}"
export EIP7805_FORK_VERSION="${EIP7805_FORK_VERSION:-0x90000000}"
export EIP7805_FORK_EPOCH="${EIP7805_FORK_EPOCH:-99999}"

This causes the config.yaml file rendered incorrectly

Image

Therefore, when you run the genesis generation command. You are getting the following error

# command
        docker run --rm -it \
        -u 0 \
        -v /home/ubuntu/output:/data \
        -v /home/ubuntu/config/values.env:/config/values.env \
        ethpandaops/ethereum-genesis-generator:master all

# error
+ /usr/local/bin/eth2-testnet-genesis deneb --config /data/metadata/config.yaml --mnemonics /tmp/ci-y7ZCL8AmAc/mnemonics.yaml --tranches-dir /data/metadata/tranches --state-output /data/metadata/genesis.ssz --preset-phase0 mainnet --preset-altair mainnet --preset-bellatrix mainnet --preset-capella mainnet --preset-deneb mainnet --eth1-config /data/metadata/genesis.json
zrnt version: v0.33.1
failed to decode config: yaml: line 49: could not find expected ':'
@nickkounz
Copy link
Author

@parithosh If possible can you please take a look?

@parithosh
Copy link
Member

thanks for the bug report, this commit fixes it! 189b9aa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants