From 6c3fc5cb25bd88a8f08e42fe755d123635567ad9 Mon Sep 17 00:00:00 2001 From: Acha Bill Date: Tue, 3 Dec 2024 19:54:02 -0500 Subject: [PATCH 1/2] fix: save tags when upload with websocket --- pkg/api/chunk_stream.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/api/chunk_stream.go b/pkg/api/chunk_stream.go index 4ae045a9d4f..55f28ceb51d 100644 --- a/pkg/api/chunk_stream.go +++ b/pkg/api/chunk_stream.go @@ -14,8 +14,8 @@ import ( "github.com/ethersphere/bee/v2/pkg/jsonhttp" "github.com/ethersphere/bee/v2/pkg/log" "github.com/ethersphere/bee/v2/pkg/postage" - storage "github.com/ethersphere/bee/v2/pkg/storage" - storer "github.com/ethersphere/bee/v2/pkg/storer" + "github.com/ethersphere/bee/v2/pkg/storage" + "github.com/ethersphere/bee/v2/pkg/storer" "github.com/ethersphere/bee/v2/pkg/swarm" "github.com/gorilla/websocket" ) @@ -56,7 +56,7 @@ func (s *Service) chunkUploadStreamHandler(w http.ResponseWriter, r *http.Reques } // if tag not specified use direct upload - putter, err := s.newStamperPutter(r.Context(), putterOptions{ + putter, err := s.newStamperPutter(context.Background(), putterOptions{ BatchID: headers.BatchID, TagID: tag, Deferred: tag != 0, From 8d267b7fc86cc19c93135c79a67433506c4dd9fa Mon Sep 17 00:00:00 2001 From: Acha Bill Date: Fri, 10 Jan 2025 03:59:24 -0500 Subject: [PATCH 2/2] chore: added clarifying comment --- pkg/api/chunk_stream.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/api/chunk_stream.go b/pkg/api/chunk_stream.go index 55f28ceb51d..2f91939f21a 100644 --- a/pkg/api/chunk_stream.go +++ b/pkg/api/chunk_stream.go @@ -56,6 +56,7 @@ func (s *Service) chunkUploadStreamHandler(w http.ResponseWriter, r *http.Reques } // if tag not specified use direct upload + // Using context.Background here because the putter's lifetime extends beyond that of the HTTP request. putter, err := s.newStamperPutter(context.Background(), putterOptions{ BatchID: headers.BatchID, TagID: tag,