Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting Klaytn network #2504

Open
hwnahm opened this issue Jan 6, 2022 · 2 comments
Open

Supporting Klaytn network #2504

hwnahm opened this issue Jan 6, 2022 · 2 comments
Labels
enhancement New feature or improvement.

Comments

@hwnahm
Copy link

hwnahm commented Jan 6, 2022

According to Klaytn network manual (https://docs.klaytn.com/bapp/json-rpc/api-references/klay/transaction)
they returns the transaction type value as a string.

Because of this when get receipt this error happens:
Unhandled Rejection (Error): invalid BigNumber string (argument="value", value="TxTypeLegacyTransaction", code=INVALID_ARGUMENT, version=bignumber/5.5.0)

I think just adding a line of code which is not perfect but mitigates the error:

At 195 line of providers/src.ts/formatter.ts
if (typeof(number) === "string") { return 0; }

and 126 line need to be:
cumulativeGasUsed: Formatter.allowNull(bigNumber);

@benjioh5
Copy link

benjioh5 commented Feb 16, 2022

On #644 , there was a some discussion. And Klaybank made some fork of ethersjs for klaytn.

https://github.com/klaybank/ethers_providers_klaytn

@ricmoo
Copy link
Member

ricmoo commented Mar 19, 2022

FYI: This is coming in v6, which is far more flexible in its network support. :)

@ricmoo ricmoo added the enhancement New feature or improvement. label Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement.
Projects
None yet
Development

No branches or pull requests

3 participants