Replies: 1 comment 3 replies
-
Yes. It definitely should. And now that I have scripts to perform minor version bumps, I will add this in the next minor version, since it does impact signatures. Good call! :) |
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
(I think this feels more like a discussion/question than an actual issue, so I've placed it here 😬 )
Right now the type definition is
export type BigNumberish = BigNumber | Bytes | string | number;
, but it seems BigInt's are supported anywhere BigNumber is supported, so perhaps this should beexport type BigNumberish = BigNumber | Bytes | string | number | bigint;
Currently trying to pass a BigInt when BigNumberish is expected gives
Argument of type 'bigint' is not assignable to parameter of type 'BigNumberish'. ts(2345)
Beta Was this translation helpful? Give feedback.
All reactions