Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a --registry option for custom ens deployments #1095

Closed
wants to merge 0 commits into from

Conversation

Amxx
Copy link

@Amxx Amxx commented Oct 8, 2020

This is a PR to fix ethers-io/ethers-cli#6. The --registry option allows a user to select a custom ens deployment, which is particularly usefull for chains where there is no official deployment.

Example:

node packages/cli/lib/bin/ethers-ens.js \
    --rpc https://bellecour.iex.ec \
    --registry 0x5f5B93fca68c9C79318d1F3868A354EE67D8c006 \
    lookup core.v5.iexec.eth

Note: Some custom have no controller/registrar/legacyRegistrar, so I had to make the getter form these safe (return null is nothing found) and add checks in the different plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom ens registry in ethers-cli
1 participant