Fix error message in runTx #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, can you maybe rebase? seems to be outdated |
|
@s1na I know it's not optimal, but from my perspective it's also ok (for the reviewer) to use the "Update branch" functionality in relatively safe cases. Bloats commit history a bit but eases workflow, especially if we operate in different time zones. From my perspective this would be such a case, but please judge yourself, also let me know your general stance on this. |
|
I haven't yet tried this functionality, but I think it makes sense for relatively safe cases, and we can always do squash and merge to prevent bloating commit history. I will try this now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error message in
runTx. A template string was missing a{.