-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split executeMessage into executeCall, executeCreate #499
Conversation
Just as a note: this still includes the commits from the previous PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the repeated commits: directly did the review, looks great, Interpreter
is beautifully readable now, also had some laid back all-file look on this to get a bit the broader picture.
Feel free to merge, thanks Sina.
This PR:
executeMessage
and movescall
orcreate
specific logic to_executeCall
and_executeCreate
. I think the differences between the two are more than the similarities, and it warrants two separate methods. It also prepares for moving call/create logic fromEEI
toInterpreter
_executeCreate
is a relatively big function, this will be further broken down in future_reduceSenderBalance
and_addToBalance
to the bottom (they'll have to eventually be removed and moved tostateManager
or something similar)(To be merged into #479)