Promisify runTx internals #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain the purpose/motivation for this a bit more? |
|
This is part of the code modernization effort. Trying to use promises in the whole code base. Migration to typescript can also later build on this. I'm doing the same for |
holgerd77
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promisifies the internals of runTx by introducing an async method
_runTxwhichrunTxcalls. For now most of the code which was inrunTxis inside_runTxas is, without breaking them into separate methods. I'm thinking of abstracting some common patterns (betweenrunTx,InterpreterandrunBlock) e.g. updating an account's balance in future.(To be merged into #479)