Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promisify async opcode handlers #491

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Promisify async opcode handlers #491

merged 1 commit into from
Apr 5, 2019

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Apr 5, 2019

Async opcode handlers now return a promise instead of accepting a callback as argument.

(To be merged into #479)

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 95.187% when pulling 261f99d on refactor/promisify-async-opfns into ca3374a on v4.

holgerd77
holgerd77 approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice choice and and also really nice weekend-closing. 😁

Read through all the code changes, looks good, tests are passing, will approve.

Thanks a lot Sina. 🙂

@s1na
Copy link
Contributor Author

s1na commented Apr 5, 2019

Thanks for the review 😃 have a nice weekend :)

@s1na s1na merged commit ed5b1a9 into v4 Apr 5, 2019
@s1na s1na deleted the refactor/promisify-async-opfns branch April 5, 2019 13:21
@s1na s1na mentioned this pull request Apr 5, 2019
Merged
23 tasks
@holgerd77
Copy link
Member

Yeah, you as well enjoy the weekend! ☕🙂🎶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s1na @coveralls @holgerd77 @evertonfraga