Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

An in-range update of rlp is breaking the build 🚨 #220

Closed
greenkeeper bot opened this issue Nov 1, 2019 · 5 comments
Closed

An in-range update of rlp is breaking the build 🚨 #220

greenkeeper bot opened this issue Nov 1, 2019 · 5 comments

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Nov 1, 2019

The dependency rlp was updated from 2.2.3 to 2.2.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rlp is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Release Notes for v2.2.4 - Bugfix Release
  • Removed unused Dictionary Input type for RLP.encode() and RLP.decode(),
    PR #74
  • Removed unused safe-buffer dependency,
    PR #80
Commits

The new version differs by 10 commits.

  • a0fc75b Merge pull request #84 from ethereumjs/new-release-v224
  • e69580f Bumped version to v2.2.4, added CHANGELOG entry
  • 997f69b Merge pull request #80 from AndreasGassmann/feat/remove-safe-buffer
  • b76356d Removed unused dependency "safe-buffer"
  • f06a96f Merge pull request #75 from ethereumjs/org-links-and-git-hooks
  • b678a97 Added husky (Git hooks) dependency and pre-push hook to package.json
  • 22d064a Added EthereumJS footer with organization docs linking
  • c633f64 Added contributing file to .github folder
  • 2bdc87f Merge pull request #74 from ethereumjs/remove-dictionary
  • 5924724 Remove Dictionary type

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@holgerd77
Copy link
Member

@alcuadrado Hmm, we might have acted a bit premature here. 🤔

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Nov 1, 2019

After pinning to 2.2.3 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

@holgerd77
Copy link
Member

@alcuadrado Update: ah, I rather think it's this common Travis error with xvfb, since the build is breaking pretty early in the process.

For reference: ethereumjs/merkle-patricia-tree#97

@alcuadrado
Copy link
Member

I think it's that error again. I got a little scared about this issue when I first saw it 😅

I think we can use chrome headless instead of firefox to avoid this kind of desktop-services error in the future.

@ryanio
Copy link
Contributor

ryanio commented Feb 5, 2020

This issue looks outdated since 2.2.4 is being used and builds/tests are passing fine.

The package.json defines rlp with ^2.2.3 so it is in range. I'll close this issue, but I can bump the version in a PR if you would like me to.

@ryanio ryanio closed this as completed Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants